Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add q revo/p10 support #114

Merged
merged 7 commits into from
Sep 4, 2023
Merged

feat: add q revo/p10 support #114

merged 7 commits into from
Sep 4, 2023

Conversation

Jezza34000
Copy link
Contributor

@Jezza34000 Jezza34000 commented Sep 4, 2023 •
edited
Loading

  • Adding class for FanSpeed
  • Adding class for MopMode (only 2 for Q REVO)
  • Adding const
  • Adding many status from Q REVO get_status (some are unknow) : 
    1. wash_status: ???

    2. distance_off: ???

    3. in_warmup: ???

    4. dry_status: 1-> Air dryer running 0-> Not running

    5. rdt: Remaing Dryer Time (Count down timer in second)

    6. clean_percent: From 0 to 100 in percent

    7. rss: ???

    8. dss: ???

    9. common_status: ???

    10. corner_clean_mode: ???

@Jezza34000 Jezza34000 mentioned this pull request Sep 4, 2023
Closed
Lash-L
Lash-L previously approved these changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@Lash-L Lash-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me. Optional should cover our bases

@Lash-L
Copy link
Collaborator

Lash-L commented Sep 4, 2023

Fix ci though please. Lint is more important than commit lint - I can fix that when merging

@Lash-L
Copy link
Collaborator

Lash-L commented Sep 4, 2023 •
edited
Loading

Also does this really make any changes regarding q revo?

Edit: I see q revo =p10?

@Jezza34000
Copy link
Contributor Author

Yes roborock.vacuum.a75 is Q REVO or P10
I think P10 is the CN name, and Q REVO for rest of the world

@Jezza34000
Copy link
Contributor Author

OK i change my PR. mop_mode/route is exaclty same as S8ProUltra.
Commitlint should be ok, and i Black my code.

@Jezza34000
Copy link
Contributor Author

Maybe we need a more generical name for class RoborockMopModeS8ProUltra(RoborockMopModeCode)
Now it's used by S8ProUltra And Q Revo

@Lash-L Lash-L mentioned this pull request Sep 4, 2023
Closed
@Lash-L
Copy link
Collaborator

Lash-L commented Sep 4, 2023 •
edited
Loading

Please run pre-commit not just black. Or manually fix the issues listed in the failed ci check.

Made the changes myself so I could merge in.

@Lash-L Lash-L changed the title feat: add Q REVO / P10 support feat: add q revo/p10 support Sep 4, 2023
@Lash-L Lash-L merged commit b2237d9 into humbertogontijo:main Sep 4, 2023
@Jezza34000
Copy link
Contributor Author

Hello thank you. 👍
I enabled the pre-commit hook for the next commits

@Jezza34000 Jezza34000 mentioned this pull request Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lash-L Lash-L Lash-L approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jezza34000 @Lash-L